Wireshark-commits: [Wireshark-commits] master df8b5cb: Detect spurious retransmissions when the ful

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 24 Mar 2016 00:04:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=df8b5cbdc0d012c750a5ae08885a57e0de13ebc5
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

df8b5cb by Michael Cistera (michael.cistera@xxxxxxxxxxxx):

    Detect spurious retransmissions when the full segment is retransmitted
    
    The TCP dissector failed to recognize spurious retransmissions when the last ack
    exactly equaled the retransmitted packet's sequence number plus the len. This is
    standard TCP behavior so this feature was broken in most cases.
    
    Bug: 12282
    Change-Id: I90196cc79e786f92fd0d7be32816aad1d69d5718
    Reviewed-on: https://code.wireshark.org/review/14592
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  5a16675   3GPP NAS: upgrade dissector to v13.5.0
    adds  df8b5cb   Detect spurious retransmissions when the full segment is retransmitted


Summary of changes:
 epan/dissectors/packet-tcp.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)