Wireshark-commits: [Wireshark-commits] master-2.0 99d549f: PKTC must be stricter with its Kerberos

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Mar 2016 02:12:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=99d549fc0208075345662a0ad6aeedfeda90bf29
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

99d549f by Michael Mann (mmann78@xxxxxxxxxxxx):

    PKTC must be stricter with its Kerberos application choices.
    
    The PKTC dissector calls the Kerberos dissector assuming certain application values.  Because different application values can have different "private" data, corruption can occur.
    Ensure the Kerberos application values match the preceding comments by checking the ber identifier before calling the Kerberos dissector.
    
    Bug: 12206
    Change-Id: I9b04837f93a56681cae3816278315cf01da17544
    Reviewed-on: https://code.wireshark.org/review/14540
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8b7bea0   More "FT_BOOLEAN is 64-bit" fixes.
    adds  99d549f   PKTC must be stricter with its Kerberos application choices.


Summary of changes:
 asn1/kerberos/kerberos.cnf        |    2 +
 epan/dissectors/packet-kerberos.c |   92 ++++++++++++++++++-------------------
 epan/dissectors/packet-kerberos.h |   20 ++++++++
 epan/dissectors/packet-pktc.c     |   21 ++++++++-
 4 files changed, 87 insertions(+), 48 deletions(-)