Wireshark-commits: [Wireshark-commits] master 1e60d63: Create call_data_dissector() to call data di
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 20 Mar 2016 17:38:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1e60d63c8c6882c8c0bdb00cf6df594e1bb6fccf Submitter: Michael Mann (mmann78@xxxxxxxxxxxx) Changed: branch: master Repository: wireshark Commits: 1e60d63 by Michael Mann (mmann78@xxxxxxxxxxxx): Create call_data_dissector() to call data dissector. This saves many dissectors the need to find the data dissector and store a handle to it. There were also some that were finding it, but not using it. For others this was the only reason for their handoff function, so it could be eliminated. Change-Id: I5d3f951ee1daa3d30c060d21bd12bbc881a8027b Reviewed-on: https://code.wireshark.org/review/14530 Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx> Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx> Actions performed: from 2b2fc64 Fix incorrect table being used to store Session Tickets adds 1e60d63 Create call_data_dissector() to call data dissector. Summary of changes: debian/libwireshark0.symbols | 1 + epan/dissectors/asn1/cdt/cdt.cnf | 4 +- epan/dissectors/asn1/cdt/packet-cdt-template.c | 4 -- epan/dissectors/asn1/gsm_map/gsm_map.cnf | 2 +- .../asn1/gsm_map/packet-gsm_map-template.c | 2 - epan/dissectors/asn1/inap/inap.cnf | 2 +- epan/dissectors/asn1/inap/packet-inap-template.c | 2 - epan/dissectors/asn1/tetra/packet-tetra-template.c | 4 -- epan/dissectors/file-file.c | 11 +--- epan/dissectors/packet-3com-xns.c | 4 +- epan/dissectors/packet-6lowpan.c | 14 ++--- epan/dissectors/packet-9p.c | 9 +-- epan/dissectors/packet-adb_cs.c | 4 +- epan/dissectors/packet-adwin.c | 11 ++-- epan/dissectors/packet-aeron.c | 4 +- epan/dissectors/packet-afp.c | 4 +- epan/dissectors/packet-ansi_a.c | 4 +- epan/dissectors/packet-ap1394.c | 6 +- epan/dissectors/packet-arcnet.c | 4 +- epan/dissectors/packet-aruba-erm.c | 6 +- epan/dissectors/packet-aruba-papi.c | 5 +- epan/dissectors/packet-asf.c | 5 +- epan/dissectors/packet-atalk.c | 19 +++--- epan/dissectors/packet-atm.c | 8 +-- epan/dissectors/packet-atmtcp.c | 5 +- epan/dissectors/packet-ax25-nol3.c | 5 +- epan/dissectors/packet-ax25.c | 7 +-- epan/dissectors/packet-bacnet.c | 4 +- epan/dissectors/packet-bat.c | 12 ++-- epan/dissectors/packet-batadv.c | 54 ++++++++--------- epan/dissectors/packet-bctp.c | 4 +- epan/dissectors/packet-bluetooth.c | 8 +-- epan/dissectors/packet-bssap.c | 8 +-- epan/dissectors/packet-bssgp.c | 11 ++-- epan/dissectors/packet-btavctp.c | 15 ++--- epan/dissectors/packet-btbnep.c | 6 +- epan/dissectors/packet-bthcrp.c | 5 +- epan/dissectors/packet-btrfcomm.c | 7 +-- epan/dissectors/packet-bvlc.c | 5 +- epan/dissectors/packet-capwap.c | 12 ++-- epan/dissectors/packet-cast.c | 3 - epan/dissectors/packet-cattp.c | 7 +-- epan/dissectors/packet-ccsds.c | 6 +- epan/dissectors/packet-cdp.c | 5 +- epan/dissectors/packet-cdt.c | 18 +++--- epan/dissectors/packet-cfdp.c | 5 +- epan/dissectors/packet-chdlc.c | 8 +-- epan/dissectors/packet-cisco-sm.c | 8 +-- epan/dissectors/packet-clnp.c | 12 ++-- epan/dissectors/packet-cnip.c | 4 +- epan/dissectors/packet-cosine.c | 4 +- epan/dissectors/packet-dccp.c | 4 +- epan/dissectors/packet-distcc.c | 5 +- epan/dissectors/packet-dmx.c | 5 +- epan/dissectors/packet-dsi.c | 5 +- epan/dissectors/packet-dsr.c | 5 +- epan/dissectors/packet-dtn.c | 4 +- epan/dissectors/packet-dtpt.c | 5 +- epan/dissectors/packet-dua.c | 4 +- epan/dissectors/packet-eapol.c | 4 +- epan/dissectors/packet-egd.c | 7 +-- epan/dissectors/packet-eiss.c | 4 +- epan/dissectors/packet-enc.c | 5 +- epan/dissectors/packet-enip.c | 8 +-- epan/dissectors/packet-epl.c | 8 +-- epan/dissectors/packet-erf.c | 18 ++---- epan/dissectors/packet-eth.c | 6 +- epan/dissectors/packet-ethertype.c | 11 +--- epan/dissectors/packet-fc.c | 10 +--- epan/dissectors/packet-fcct.c | 5 +- epan/dissectors/packet-fcels.c | 5 +- epan/dissectors/packet-fcfcs.c | 6 +- epan/dissectors/packet-fcfzs.c | 6 +- epan/dissectors/packet-fcip.c | 6 +- epan/dissectors/packet-fcoe.c | 6 +- epan/dissectors/packet-fcoib.c | 6 +- epan/dissectors/packet-fcp.c | 8 +-- epan/dissectors/packet-fcsb3.c | 10 +--- epan/dissectors/packet-fcswils.c | 5 +- epan/dissectors/packet-fddi.c | 4 +- epan/dissectors/packet-fefd.c | 5 +- epan/dissectors/packet-flexnet.c | 9 +-- epan/dissectors/packet-flexray.c | 7 +-- epan/dissectors/packet-flip.c | 6 +- epan/dissectors/packet-fmtp.c | 5 +- epan/dissectors/packet-frame.c | 8 +-- epan/dissectors/packet-geneve.c | 4 +- epan/dissectors/packet-gfp.c | 14 +---- epan/dissectors/packet-giop.c | 4 +- epan/dissectors/packet-gmr1_rach.c | 12 +--- epan/dissectors/packet-gmr1_rr.c | 11 +--- epan/dissectors/packet-gmrp.c | 32 +++------- epan/dissectors/packet-gprs-llc.c | 10 ++-- epan/dissectors/packet-gre.c | 4 +- epan/dissectors/packet-gsm_a_dtap.c | 4 +- ... 191 lines suppressed ...
- Prev by Date: [Wireshark-commits] master 2b2fc64: Fix incorrect table being used to store Session Tickets
- Next by Date: [Wireshark-commits] master 93a3041: Fix response ok packet with no session tracking info but flag set
- Previous by thread: [Wireshark-commits] master 2b2fc64: Fix incorrect table being used to store Session Tickets
- Next by thread: [Wireshark-commits] master 93a3041: Fix response ok packet with no session tracking info but flag set
- Index(es):