Wireshark-commits: [Wireshark-commits] master-2.0 3819b71: Make sure first byte in ACAP packet is p

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 20 Mar 2016 11:33:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3819b717d6f7eea4fe0b1f9890450c14cc84fbec
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

3819b71 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Make sure first byte in ACAP packet is printable.
    (Must convert dissector to "new" style)
    
    Saves some false positives for protocols using port 674.
    
    Bug: 12265
    Change-Id: I28427af88dc62c1d058bc56f6fc55e0615fbb17c
    Reviewed-on: https://code.wireshark.org/review/14525
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  c64d0ff   ASTERIX: fix for wrong RE and SP fields in CAT048.
    adds  3819b71   Make sure first byte in ACAP packet is printable. (Must convert dissector to "new" style)


Summary of changes:
 epan/dissectors/packet-acap.c |   19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)