Wireshark-commits: [Wireshark-commits] master 68b7b1a: To see whether a string equals another strin

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Mar 2016 18:11:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=68b7b1ab57529a3a45d6d0f24445c66d79366752
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

68b7b1a by Guy Harris (guy@xxxxxxxxxxxx):

    To see whether a string equals another string, just use strcmp().
    
    The goal here is to see whether out_filename is "-" or not; there's no
    good reason to use strncmp() here.
    
    Fixes Coverity CID 1316605.
    
    Change-Id: I851eee869afed58ac091982b8d303b0eda276c2e
    Reviewed-on: https://code.wireshark.org/review/14361
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ad3afb0   Properly fetch the ethertype.
    adds  68b7b1a   To see whether a string equals another string, just use strcmp().


Summary of changes:
 mergecap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)