URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3ada3c0865ecd51e1c59cfec81f9f4c67d74a920
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
3ada3c0 by D. Ulis (daulis0@xxxxxxxxx):
CIP: Improve error checking
1. Expert info for cip_short_string,cip_string
2. Combine dissect_cip_multiple_service_packet_req/dissect_cip_multiple_service_packet_rsp. The formats are the same, and this ensures that all expert info checks are applied to both.
3. Remove some copy-paste in dissect_cip_generic_data
Change-Id: I433990bf4389bee78d414cab8547bd2bb39498c7
Reviewed-on: https://code.wireshark.org/review/14105
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from b64d19b diameter: change GArray into wmem_array.
adds 3ada3c0 CIP: Improve error checking
Summary of changes:
epan/dissectors/packet-cip.c | 240 +++++++++++++++---------------------------
1 file changed, 84 insertions(+), 156 deletions(-)