Wireshark-commits: [Wireshark-commits] master-2.0 5e39136: For SHBs, always use the byte order from

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 25 Feb 2016 02:51:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e39136dadd3cf5de5413b0bf9482f5f6cb8c4b0
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

5e39136 by Guy Harris (guy@xxxxxxxxxxxx):

    For SHBs, always use the byte order from the byte-order magic.
    
    Don't use the byte order from any previously-seen SHB, as it might be
    different.
    
    Bug: 12167
    Change-Id: I19a81f81f2e8115938387487e2682b8b11a100fe
    Reviewed-on: https://code.wireshark.org/review/14131
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 84ac392e9fa1a6a897c231afcf662dc1e1a4fe91)
    Reviewed-on: https://code.wireshark.org/review/14132
    

Actions performed:

    from  14ee62e   Fix another heap-based bufffer overflow.
    adds  5e39136   For SHBs, always use the byte order from the byte-order magic.


Summary of changes:
 wiretap/pcapng.c |   55 +++++++++++++++++++++++++++++++++++-------------------
 1 file changed, 36 insertions(+), 19 deletions(-)