Wireshark-commits: [Wireshark-commits] master 5d00f39: BGP-LS: Protocol-ID aware Prefix/Adj Flags d

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 23 Feb 2016 13:08:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5d00f39d10ebba19ab2aea719606fa6b218a3658
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5d00f39 by Francesco Fondelli (francesco.fondelli@xxxxxxxxx):

    BGP-LS: Protocol-ID aware Prefix/Adj Flags dissection
    
    BGP-LS is just a collector of IGP link state information. Some
    fields are encoded "as-is" from the IGP, hence in order to dissect
    them properly we must be aware of their origin, e.g. IS-IS or OSPF.
    So, *before* dissecting LINK_STATE attributes we must get the
    'Protocol-ID' field that is present in the MP_[UN]REACH_NLRI
    attribute. The tricky thing is that there is no strict order for path
    attributes on the wire, hence we have to keep track of 1) the
    'Protocol-ID' from the MP_[UN]REACH_NLRI and 2) the offset/len of
    the LINK_STATE attribute. We store them in per-packet proto_data and
    once we got both we are ready for the LINK_STATE attribute dissection.
    
    Change-Id: Ibe2b7f5c9039ad63a72f3f9fb8a9c33c0be44ed0
    Signed-off-by: Francesco Fondelli <francesco.fondelli@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/13970
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  00bd175   Have "make maintainer-clean" remove extcap/Makefile.in.
    adds  5d00f39   BGP-LS: Protocol-ID aware Prefix/Adj Flags dissection


Summary of changes:
 epan/dissectors/packet-bgp.c |  346 +++++++++++++++++++++++++++++++++---------
 1 file changed, 276 insertions(+), 70 deletions(-)