Wireshark-commits: [Wireshark-commits] master-2.0 0865707: rsl: avoid buffer overread

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Feb 2016 17:48:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=086570731fe8573c79eecc592bd7ea466c18c934
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

0865707 by Peter Wu (peter@xxxxxxxxxxxxx):

    rsl: avoid buffer overread
    
    Fixes a buffer overrun in dissct_rsl_ipaccess_msg when the tag is
    exactly 0xff:
    
            tag = tvb_get_guint8(tvb, offset);
            tdef = &rsl_att_tlvdef.def[tag];
    
    Bug: 11829
    Change-Id: I25a3c6948242a52f59431ce84c108b2e52008930
    Reviewed-on: https://code.wireshark.org/review/14011
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit de65fd6b00d0b891930324b9549c93ccfe9cac30)
    Reviewed-on: https://code.wireshark.org/review/14012
    

Actions performed:

    from  274ce32   Qt: Update AccordionFrame widgets to use common layout
    adds  0865707   rsl: avoid buffer overread


Summary of changes:
 epan/dissectors/packet-rsl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)