Wireshark-commits: [Wireshark-commits] master b550c33: Dissection of SSAPs is a bit weird. 0x1 woul

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 13 Feb 2016 14:04:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b550c33d4a95f778cf56154fd0efc96db29b0127
Submitter: J?rg Mayer (jmayer@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b550c33 by Joerg Mayer (jmayer@xxxxxxxxx):

    Dissection of SSAPs is a bit weird. 0x1 would be displayed as ">Unknown (0x01)"
    on my particular trace. This duplicates the value with the C/R-bit set. Needs
    a proper fix eventually.
    Small indentation fix.
    
    Change-Id: I6bf7c560b5161994b8d90d7ae70724c03c6df73b
    Reviewed-on: https://code.wireshark.org/review/13926
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    

Actions performed:

    from  378c59b   iso14443: verify the CRC of all messages
    adds  b550c33   Dissection of SSAPs is a bit weird. 0x1 would be displayed as ">Unknown (0x01)" on my particular trace. This duplicates the value with the C/R-bit set. Needs a proper fix eventually. Small indentation fix.


Summary of changes:
 epan/dissectors/packet-llc.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)