Wireshark-commits: [Wireshark-commits] master 5cffcf2: Avoid undefined behavior in overflow check

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 11 Feb 2016 01:39:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5cffcf20b147ac88d58774ccce0b76db4704b329
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5cffcf2 by Michael McConville (mmcco@xxxxxxxxxxx):

    Avoid undefined behavior in overflow check
    
    Signed overflow is undefined, so testing for overflow with
    "if (i + 1 < i)" is itself undefined. Because this instance is an
    increment, we can just test against G_MAXINT.
    
    Change-Id: Ib8b7c23ec362d5637125fcf6457ea9423fedf0e1
    Reviewed-on: https://code.wireshark.org/review/13896
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7b88834   mq: enable SSL dissection
    adds  5cffcf2   Avoid undefined behavior in overflow check


Summary of changes:
 wiretap/merge.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)