Wireshark-commits: [Wireshark-commits] master 4a2cd6c: llrp: limit recursion depth

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 6 Feb 2016 14:38:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a2cd6c79ecbf2cb21f985f01ce1c1e3030285ec
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4a2cd6c by Evan Huus (eapache@xxxxxxxxx):

    llrp: limit recursion depth
    
    LLRP defines fairly complex parameter nesting which we handle via recursion,
    however this means a large crafted packet could cause very deep stacks and
    potentially stack overflows. Limit our recursive depth to an arbitrary, which
    should be more than enough for any legitimate packet (I hope).
    
    Bug: 12048
    Change-Id: I9ac31bddfa4ffd1a79809387d10d2261749b95e7
    Reviewed-on: https://code.wireshark.org/review/13794
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  47fc7ff   asn1: Cleanup space usage
    adds  4a2cd6c   llrp: limit recursion depth


Summary of changes:
 epan/dissectors/packet-llrp.c |   67 +++++++++++++++++++++--------------------
 1 file changed, 35 insertions(+), 32 deletions(-)