Wireshark-commits: [Wireshark-commits] lts-1.12.1 f490c70: Replace my_dgt_tbcd_unpack with the safe

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 5 Feb 2016 20:43:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f490c70b74de5028e28dad85f270f8bbcbf385ca
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

f490c70 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Replace my_dgt_tbcd_unpack with the safer tvb_bcd_dig_to_wmem_packet_str.
    
    Bug: 11797
    Change-Id: Iecca888d68e7710b871fa67af2a1174a294d9594
    Reviewed-on: https://code.wireshark.org/review/12273
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 8194323b2f53b9f5accc85d9a005eba1d029c91a)
    Reviewed-on: https://code.wireshark.org/review/13766
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  52c0588   RSVP: copy all rsvp_request_key info in file scope
    adds  f490c70   Replace my_dgt_tbcd_unpack with the safer tvb_bcd_dig_to_wmem_packet_str.


Summary of changes:
 epan/dissectors/packet-ansi_a.c       |  139 ++++++++-------------------------
 epan/dissectors/packet-gsm_a_common.c |   61 ++-------------
 epan/dissectors/packet-gsm_a_common.h |    6 --
 epan/dissectors/packet-gsm_a_dtap.c   |   12 +--
 4 files changed, 39 insertions(+), 179 deletions(-)