URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c09d894f7446aa394d04710876ed631af22b1497
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
c09d894 by Michal Labedzki (michal.labedzki@xxxxxxxxx):
Fix some Coverity issue
>>> CID 1349726: Incorrect expression (COPY_PASTE_ERROR)
>>> "tvb_reported_length_remaining" in "tvb_reported_length_remaining(tvb, offset)" looks like a copy-paste error.
>>> CID 1349727: Incorrect expression (COPY_PASTE_ERROR)
>>> "tree" in "dissector_try_uint_new(bluetooth_eir_ad_manufacturer_company_id, company_id, new_tvb, pinfo,
>>> CID 1349728: (DEADCODE)
>>> Execution cannot reach this expression "0" inside statement "(0 && ((__s1_len = __builti...".
>>> CID 1306904: Logically dead code (DEADCODE)
>>> Execution cannot reach this statement "tap_hci_summary->interface_...".
Change-Id: I5f99e37e6d5fac39da7082649caa8373d06bb808
Reviewed-on: https://code.wireshark.org/review/13739
Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Actions performed:
from fb033d0 Add CIP Security objects
adds c09d894 Fix some Coverity issue
Summary of changes:
epan/dissectors/packet-bthci_cmd.c | 12 +++-----
epan/dissectors/packet-bthci_evt.c | 60 +++++++++++-------------------------
epan/dissectors/packet-btle.c | 6 ++--
extcap/androiddump.c | 4 +++
4 files changed, 29 insertions(+), 53 deletions(-)