Wireshark-commits: [Wireshark-commits] master 6641987: usb: don't THROW() an exception from a disse

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 2 Feb 2016 16:44:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6641987c8925dc9e1ed8be1f86d4e472170f3c82
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6641987 by Martin Kaiser (wireshark@xxxxxxxxx):

    usb: don't THROW() an exception from a dissector
    
    the code in question deals with the scenario where the length field's
    value is larger than the number of remaining bytes
    
    we can simply stop the dissection if truncation of the data is expected
    
    if not, we continue disecting and we'll get an exception when we reached
    the end of the data...
    
    Change-Id: I3f29df694d9ea7d41f19511d267ef6b785527e3c
    Reviewed-on: https://code.wireshark.org/review/13624
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  cb241e9   [GSM MAP] Update to V13.2.0 (2015-12)
    adds  6641987   usb: don't THROW() an exception from a dissector


Summary of changes:
 epan/dissectors/packet-usb.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)