URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=214f040287acac10d728ce443d3b3b820018816b
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark
Commits:
214f040 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Make Qt UI capture filter behavior more closely match the GTK+ UI.
If the user enters a capture filter in the Capture Interfaces dialog and
presses "Start", make sure we copy the filter to the main welcome
screen.
Back out capture filter code from g0ce9ac4. Leave out the code that set
the global capture filter. Move the code that set individual capture
filters to the welcome screen.
Fix multiple interface selection in the welcome screen.
Rename allFilterComboBox in the capture interfaces dialog to
captureFilterComboBox to match the main welcome screen.
If the user starts typing in captureFilterComboBox, make sure the
"Capture Filter" column is visible. Update the "Capture Filter" column
as the user types. Conversely, if the user edits the "Capture Filter"
column, update captureFilterComboBox accordingly.
If we're editing a per-interface filter make sure we commit its contents
before starting capture.
Map our device index directly to each tree item instead of using a
separate map which will no longer be valid any time our sort order
changes (which we do right away in our constructor).
Don't set prefs.capture_devices_filter in the Qt UI. The GTK+ UI doesn't
and doing so can lead to surprising behavior. Note that it's mostly
unused.
Note that we don't multiple selected filters very well.
Conflicts:
ui/qt/capture_interfaces_dialog.cpp
Ping-Bug: 11886
Change-Id: I3c052f4f464411e2fb8fb7d96b218e1ce2bac3fd
Reviewed-on: https://code.wireshark.org/review/13410
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
(cherry picked from commit e57bb1919c80a2d1c245d539f6450b9b9defcb68)
Reviewed-on: https://code.wireshark.org/review/13655
Actions performed:
from 2e40d66 "#ifdef" out a definition not used if HAVE_LIBPCAP isn't defined.
adds 214f040 Make Qt UI capture filter behavior more closely match the GTK+ UI.
Summary of changes:
epan/prefs.h | 2 +-
ui/qt/capture_interfaces_dialog.cpp | 126 ++++++++++++++++++++++-------------
ui/qt/capture_interfaces_dialog.h | 8 ++-
ui/qt/capture_interfaces_dialog.ui | 6 +-
ui/qt/interface_tree.cpp | 10 +--
ui/qt/main_welcome.cpp | 43 ++++++++++++
ui/qt/main_welcome.h | 2 +
ui/qt/main_window.h | 7 +-
ui/qt/main_window_slots.cpp | 38 ++---------
9 files changed, 150 insertions(+), 92 deletions(-)