URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=936e4e01231a5df9dead93ac40bb2b4f923c2754
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
936e4e0 by Luke Mewburn (luke@xxxxxxxxxxx):
correctly decode GSM_MAP invoke SRISMv1
The decoding of application context version 1
SendRoutingInfoForSM (SRISM) invokes (added in bug 9704)
had issues:
- The ASN.1 for RoutingInfoForSM-ArgV1 in GSMMAP.asn
lacked teleserviceCode and the extension marker.
ETSI ETS 300 599 (GSM 09.02 version 4.19.1) clause 14.7.6
has teleserviceCode and the extension marker, but not cug-Interlock.
Clause C.6.4 mentions that cug-Interlock has been deleted,
but it's retained here for decoding backwards compat.
- The test for which application_context_version to decode as
didn't work when that value was 0 (i.e. missing).
Ping-Bug: 9704
Change-Id: I8a8170d959347a47413cfd9876022e9182256452
Reviewed-on: https://code.wireshark.org/review/13571
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from eeae61b packet-simple: SIMPLE dissector
adds 936e4e0 correctly decode GSM_MAP invoke SRISMv1
Summary of changes:
asn1/gsm_map/GSMMAP.asn | 4 ++--
asn1/gsm_map/packet-gsm_map-template.c | 2 +-
epan/dissectors/packet-gsm_map.c | 8 +++++++-
3 files changed, 10 insertions(+), 4 deletions(-)