Wireshark-commits: [Wireshark-commits] master 0f5bed3: ssl: fix RSA key matching with Client certs

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 Jan 2016 21:05:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0f5bed39fe90659615b192d9a88d7d206d349fff
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0f5bed3 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl: fix RSA key matching with Client certs
    
    Avoid a RSA private key lookup for client certificates, the RSA private
    key is only valid for the server certificate. The lookup based on the
    client cert resulted in overwriting the server match.
    
    Bug: 12042
    Change-Id: I60aa79f8f2b941bfde032e20ab11446ae4e6c81b
    Reviewed-on: https://code.wireshark.org/review/13530
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  623e536   phdr->pkt_encap and phdr->pkt_tsprec need to be set for seek-read too.
    adds  0f5bed3   ssl: fix RSA key matching with Client certs


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)