Wireshark-commits: [Wireshark-commits] master dced679: Squelch Coverity warnings CID 1348057 and 13

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 20 Jan 2016 20:37:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dced679fcc625da2bd0a1a342e052986026424d3
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dced679 by Guy Harris (guy@xxxxxxxxxxxx):

    Squelch Coverity warnings CID 1348057 and 1348058.
    
    No need to use FI_SET_FLAG() in proto_tree_add_item_ret_{u}int() - by
    the time we call it, we already know that new_fi is non-null, so we
    don't need a wrapper that checks for it being null.
    
    Change-Id: Id00418e73c2ede97388a01eb12c8c94743291853
    Reviewed-on: https://code.wireshark.org/review/13460
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a2b1f39   Better handle TCP conversations when ports are reused.
    adds  dced679   Squelch Coverity warnings CID 1348057 and 1348058.


Summary of changes:
 epan/proto.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)