Wireshark-commits: [Wireshark-commits] master-2.0 60aec83: Call the "no FCS present" version of the

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 17 Jan 2016 04:04:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=60aec83e94ce580947f5a38aa6089c2abe673b45
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

60aec83 by Guy Harris (guy@xxxxxxxxxxxx):

    Call the "no FCS present" version of the Ethernet dissector.
    
    I haven't found an official spec for EoIB, but slide 10 of
    
    	http://downloads.openfabrics.org/Media/Sonoma2009/Sonoma_2009_Tues_converged-net-bridging.pdf
    
    shows the "Eth Payload" following the "Eth Header" and optional "Vlan
    tag", and doesn't show an FCS; "Payload" generally refers to the data
    transported by the protocol, which wouldn't include the FCS.
    
    In addition, the capture attached to bug 5061 includes no Ethernet FCS.
    
    So we assume the Ethernet frames carried by EoIB don't include the
    Ethernet FCS.
    
    Bug: 9933
    Change-Id: I310e5727c42e05498d1f1df08266a48fd6674388
    Reviewed-on: https://code.wireshark.org/review/13351
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 2c3d3435922e5b7da2d3dd819ffb069ca8454664)
    Reviewed-on: https://code.wireshark.org/review/13352
    

Actions performed:

    from  33e52b0   Use the "no FCS" version of the Ethernet dissector.
    adds  60aec83   Call the "no FCS present" version of the Ethernet dissector.


Summary of changes:
 epan/dissectors/packet-infiniband.c |   20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)