Wireshark-commits: [Wireshark-commits] master d89de40: Not passing a struct atm_phdr to an ATM diss

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 15 Jan 2016 21:36:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d89de40449616c92d996e9314bcced9ab2fc5198
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d89de40 by Guy Harris (guy@xxxxxxxxxxxx):

    Not passing a struct atm_phdr to an ATM dissector is a bug.
    
    Check for it with DISSECTOR_ASSERT().
    
    Change-Id: I71ba81107f7a4aff21b0f0dbecb5158dc4ff6238
    Reviewed-on: https://code.wireshark.org/review/13318
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a9e126a   ATM: do not try to dissect if pseudo header is not present
    adds  d89de40   Not passing a struct atm_phdr to an ATM dissector is a bug.


Summary of changes:
 epan/dissectors/packet-atm.c |   16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)