Wireshark-commits: [Wireshark-commits] master bebb63b: Keep comments from stealing hierarchy statis

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 15 Jan 2016 17:56:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bebb63bea9cf58665a31c78abcbbe82658b1e49d
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bebb63b by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Keep comments from stealing hierarchy statistics.
    
    If a packet has a comment, the Protocol Hierarchy Statistics dialog will
    add its stats to a top-level "Packet comments" node instead of the
    "Frame" node. Add a check for the pkt_comment protocol ID and skip over
    it if we find it. Affects Wireshark 2.0, 1.12, 1.10, and probably
    earlier versions.
    
    As an alternative we could always force "Frame" to be the first item in
    the tree.
    
    Change-Id: If7cd817071caf6219515f5d8121b3a1a2c0d79a6
    Reviewed-on: https://code.wireshark.org/review/13297
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  3b2e7b6   Always initialize need_colorize flag
    adds  bebb63b   Keep comments from stealing hierarchy statistics.


Summary of changes:
 ui/proto_hier_stats.c |   15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)