Wireshark-commits: [Wireshark-commits] master b4a1985: [airpcap] Fix parsing of GTK

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 14 Jan 2016 05:24:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b4a1985cef117426a5ec872cadbbf536dd0c636d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b4a1985 by Cedric Izoard (cedric.izoard@xxxxxxxxxxxx):

    [airpcap] Fix parsing of GTK
    
    - When parsing key data for GTK, check both the IE ID (0xdd) and OUI-type (00-0F-AC 1)
    as key data may contains more that one IE with ID (0xdd) and GTK KDE is not always the first one
    
    - Determine key type (TKIP/CCMP) based on actual key length and not size of the whole key_data part
    
    - Remove arbitrary limit on size of key_data
    
    Bug: 11973
    Change-Id: I8f71fe970c07a092131eada2be3936c12a61cdd5
    Reviewed-on: https://code.wireshark.org/review/13182
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8fe1cf7   Fix capture output options.
    adds  b4a1985   [airpcap] Fix parsing of GTK


Summary of changes:
 epan/crypt/airpdcap.c |   98 ++++++++++++++++++++++---------------------------
 1 file changed, 44 insertions(+), 54 deletions(-)