Wireshark-commits: [Wireshark-commits] master 161047c: Enable USB sub-dissectors for MA USB.

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 13 Jan 2016 20:36:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=161047ce0688569d2e273bcef8fb47b4f0c322c8
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

161047c by Sean O. Stalley (sean.stalley@xxxxxxxxx):

    Enable USB sub-dissectors for MA USB.
    
    MA USB packets with USB payload are now passed into the USB dissector.
    This allows the payload to be dissected by the USB sub-dissectors.
    
    1.  Refactor dissect_usb_common() and put the code needed for finding USB subdissectors
    into a seperate helper function.
    2.  Add dissect_usb_payload() call
    3.  Add dissect_mausb_pkt_common() helper function
    4.  Put code for dissecting all types of MA USB packets into helper
    function dissect_mausb_pkt().
    5.  Add dissect_mausb_pkt_data() helper function
    6.  Put code for dissecting MA USB datapacket-specific fields into helper
    function dissect_mausb_pkt().
    7.  Use proto_tree_add_bitmask() call for MA USB bitfields.
    8.  Create packet-mausb.h to expose MA definitions to USB dissector
    9.  Dissect MA USB payload with USB subdissectors
    10. Undeclare USB calls no longer used by MA USB dissector
    
    Change-Id: I456714572cd8dfc9982b087670ca73c17e25a26c
    Signed-off-by: Sean O. Stalley <sean.stalley@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/13187
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  57252ad   Do not filter on "http" when Following HTTP streams.
    adds  161047c   Enable USB sub-dissectors for MA USB.


Summary of changes:
 epan/dissectors/Makefile.common |    1 +
 epan/dissectors/packet-mausb.c  |  563 ++++++++++++++-------------------------
 epan/dissectors/packet-mausb.h  |   86 ++++++
 epan/dissectors/packet-usb.c    |  145 +++++-----
 epan/dissectors/packet-usb.h    |   43 ++-
 5 files changed, 393 insertions(+), 445 deletions(-)
 create mode 100644 epan/dissectors/packet-mausb.h