URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f83e20202f2530b5ca51969bdc5c7cf23d69e498
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
f83e202 by Hanspeter Portner (dev@xxxxxxxxxxxxxxxxxxxxxxxxx):
[OSC] implement SLIP framing via TCP for OSC-1.1.
OSC-1.1 requires OSC packets to be double SLIP encoded on a TCP stream
for framing, whereas OSC-1.0 frames packets via a int32 size prefix.
As only either OSC-1.0 or OSC-1.1 will ever be used on the same
connection, the tcp part of the OSC dissector should handle both.
'dissect_osc_tcp' now merely acts as a fork into one of both versions.
Changes:
* Reassembly for OSC-1.0 TCP is left untouched.
* Reassembly for OSC-1.1 TCP is implemented in second reassembly mode.
* OSC is no protocol per se, it's merely an encoding, renamed accordingly.
* Fix logical vs binary OR typo in MIDI pitch bend calculation.
Capture file:
* Mixed framing (OSC-1.0, OSC-1.1) OSC TCP pcap: Bug 11976
Change-Id: I5d26db023ef3ee659ae5a668b1665abef40b54c3
Reviewed-on: https://code.wireshark.org/review/13112
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from fe7cbca WS_DLL_PUBLIC_DEF is for definitions; WS_DLL_PUBLIC is for declarations.
adds f83e202 [OSC] implement SLIP framing via TCP for OSC-1.1.
Summary of changes:
epan/dissectors/packet-osc.c | 191 ++++++++++++++++++++++++++++++++++++++++--
1 file changed, 185 insertions(+), 6 deletions(-)