Wireshark-commits: [Wireshark-commits] master 3661566: Fix compile problems on OS X.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 29 Dec 2015 23:13:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=36615661d5b0bacef519a64a3cc24cf9d4270117
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3661566 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix compile problems on OS X.
    
    Apparently, the C++ compilers on the OS X buildbots don't realize that a
    reference cannot be null and therefore that there's nothing ambiguous
    about QString(NULL) - the NULL must be a "const char *".  Instead, use a
    constructed null QString.
    
    Change-Id: Ibc56ea7f84c5e49cf3b1974c3de905bf23e90ff0
    Reviewed-on: https://code.wireshark.org/review/12928
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  41ba1d7   Allow overriding of the GTK and QT versions without modifying the script.
    adds  3661566   Fix compile problems on OS X.


Summary of changes:
 ui/qt/main_window.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)