Wireshark-commits: [Wireshark-commits] master 3b39b1d: [SMTP] Combine username and password when ba

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 Dec 2015 15:41:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b39b1d226394dc013734b5cff349ad5166b94fb
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3b39b1d by Michael Mann (mmann78@xxxxxxxxxxxx):

    [SMTP] Combine username and password when base64 decoding fails or is disabled.
    
    Also add expert info "hint" that base64 decoding may be disabled.
    
    Bug: 11853
    Change-Id: Ib2138ae0c70e22f311e1369c66816ff9d6fbdb82
    Reviewed-on: https://code.wireshark.org/review/12734
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  526dcce   text2pcap: fix There are identical sub-expressions 'num_packets_written' to the left and to the right of the '-' operator found by PVS Studio (V501)
    adds  3b39b1d   [SMTP] Combine username and password when base64 decoding fails or is disabled.


Summary of changes:
 epan/dissectors/packet-smtp.c |   23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)