Wireshark-commits: [Wireshark-commits] master-2.0 fc3b6a5: [airpdcap] check the length of the WPA b

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 Dec 2015 08:11:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fc3b6a5f27dbaa559bbaea79e427cadf8df6dc18
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

fc3b6a5 by Martin Kaiser (wireshark@xxxxxxxxx):

    [airpdcap] check the length of the WPA broadcast key we calculated
    
    return an error if our key is shorter than the key type required for the
    encryption method we detected
    
    this check prevents an out-of-bounds memory access when the key is copied
    
    Bug: 11826
    Change-Id: Ic779b5d87aa97a3b2d2b2c92ce12d0fff4a85adc
    Reviewed-on: https://code.wireshark.org/review/12743
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/12769
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  4781e5a   [aidpdcap] use packet scoped wmem memory for szEncryptedKey
    adds  fc3b6a5   [airpdcap] check the length of the WPA broadcast key we calculated


Summary of changes:
 epan/crypt/airpdcap.c |    4 ++++
 1 file changed, 4 insertions(+)