URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9bb3f6be4c18822267a64633c298e1a8f1809221
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
9bb3f6b by Michal Labedzki (michal.labedzki@xxxxxxxxx):
Qt: Add missing multi-field column validation
GTK already has it, but Qt forgot about it, so multi-field custom column
works ok if previously saved in GTK-shark. Invalid validation prevent from
modifying and saving multi-field custom column in Qt version.
While at it, rename "custom field" to "custom fields" to ensure
we think about multi-field custom column.
Change-Id: I99588150ccb38be11b75f5dd5b0f6443e7055ebb
Reviewed-on: https://code.wireshark.org/review/12685
Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 7e0ec2c Create capture dissector table for LLC non-snap dissectors.
adds 9bb3f6b Qt: Add missing multi-field column validation
Summary of changes:
debian/libwireshark0.symbols | 4 +--
epan/column-info.h | 4 +--
epan/column-utils.c | 32 +++++++++----------
epan/column.c | 26 +++++++--------
epan/column.h | 6 ++--
epan/prefs.c | 62 ++++++++++++++++++------------------
ui/gtk/main.c | 2 +-
ui/gtk/main_menubar.c | 4 +--
ui/gtk/packet_list.c | 10 +++---
ui/gtk/packet_list_store.c | 2 +-
ui/gtk/prefs_column.c | 34 ++++++++++----------
ui/packet_list_utils.c | 4 +--
ui/preference_utils.c | 8 ++---
ui/qt/column_editor_frame.cpp | 26 +++++++--------
ui/qt/column_editor_frame.h | 4 +--
ui/qt/column_editor_frame.ui | 4 +--
ui/qt/column_preferences_frame.cpp | 38 +++++++++++-----------
ui/qt/column_preferences_frame.h | 4 +--
ui/qt/column_preferences_frame.ui | 2 +-
ui/qt/packet_list.cpp | 4 +--
ui/qt/packet_list_model.cpp | 2 +-
ui/qt/syntax_line_edit.cpp | 26 +++++++++++++++
ui/qt/syntax_line_edit.h | 1 +
ui/recent.c | 8 ++---
24 files changed, 172 insertions(+), 145 deletions(-)