URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2aab706c5a5d61c61bbff6e9e36a57afc4ef3be8
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
2aab706 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):
Remove -Wwrite-strings compiler flag
The "-Wwrite-strings" flag produces nuisance warnings. These warnings are
not useful, they're impossible to fix in a sane way and therefore are being
handled with casts of static strings to (char *).
This just moves the warning to [-Wcast-qual] and a compiler pragma is
in turn required (and used) to squelch that warning.
Remove the Wwrite-strings warning. Let that responsibility fall on the
programmer (as is done by casting).
Change-Id: I5a44dfd9decd6d80797a521a3373593074962fb5
Reviewed-on: https://code.wireshark.org/review/12162
Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Actions performed:
from 95142cf [iso14443] dissect the PCB byte and payload of I, R and S-blocks
adds 2aab706 Remove -Wwrite-strings compiler flag
Summary of changes:
CMakeLists.txt | 1 -
capinfos.c | 6 ++----
capture_opts.h | 28 ++++++++++++------------
captype.c | 6 ++----
configure.ac | 1 -
dumpcap.c | 6 ++----
editcap.c | 6 ++----
epan/dissectors/packet-bluetooth.c | 4 ++--
epan/dissectors/packet-dcerpc-spoolss.c | 2 +-
epan/dissectors/packet-diameter.c | 4 ++--
epan/dissectors/packet-mq.h | 4 ++--
epan/dissectors/packet-ncp2222.inc | 2 +-
epan/dissectors/packet-reload.c | 36 +++++++++++++++----------------
epan/dissectors/packet-xml.c | 4 ++--
mergecap.c | 6 ++----
plugins/wimaxasncp/packet-wimaxasncp.c | 2 +-
randpkt.c | 4 +---
rawshark.c | 6 ++----
reordercap.c | 6 ++----
text2pcap.c | 6 ++----
tfshark.c | 6 ++----
tshark.c | 6 ++----
ui/gtk/dissector_tables_dlg.c | 2 +-
ui/gtk/drag_and_drop.c | 2 +-
ui/gtk/gui_utils.c | 2 +-
ui/gtk/main.c | 12 +++++------
ui/tap-rlc-graph.c | 6 +++---
wireshark-qt.cpp | 12 +++++------
wsutil/wsgetopt.c | 2 +-
29 files changed, 81 insertions(+), 109 deletions(-)