Wireshark-commits: [Wireshark-commits] master bdf8034: Qt: Disable setStretchLastSection in the pac

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 3 Dec 2015 05:17:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bdf8034fb1a4dc33cf87f67ecf6e4c2c6cfb08be
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bdf8034 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Disable setStretchLastSection in the packet list.
    
    QTreeView sets the stretchLastSection property of its header by default.
    In our case this means that if the sum of our recent column widths
    exceeds the width of the packet list viewport QHeaderView will shrink
    the last column to fit.
    
    Disable setStretchLastSection. We want its behavior when our columns are
    too narrow so check for that in ::showEvent and temporarily enable it
    there.
    
    Bug: 11738
    Change-Id: Ia4aad63e4f4bf899891bcebb7032dc5ebeb74cc7
    Reviewed-on: https://code.wireshark.org/review/12392
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e78093f   TDS: Sanity check number of columns to prevent crash.
    adds  bdf8034   Qt: Disable setStretchLastSection in the packet list.


Summary of changes:
 ui/qt/packet_list.cpp |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)