Wireshark-commits: [Wireshark-commits] master 6655dd9: Only check for the last nibble being 0x0f.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 2 Dec 2015 01:48:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6655dd93e5d4b60798a3823b51b785d7064f6e20
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6655dd9 by Guy Harris (guy@xxxxxxxxxxxx):

    Only check for the last nibble being 0x0f.
    
    That's what my_dgt_tbcd_unpack() did; do the same thing here.
    
    Change-Id: Ia68c6ba652c748bd2661fd6eda736e880f414dc5
    Reviewed-on: https://code.wireshark.org/review/12359
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1d1a893   Add a separate expert info for "not a valid digit".
    adds  6655dd9   Only check for the last nibble being 0x0f.


Summary of changes:
 epan/tvbuff.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)