URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b932ee8f136ffeb3e78ce0f03e08df81fd18d9d4
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
b932ee8 by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):
Qt Frames: Use ButtonBox instead of buttons
In these frames the Ok and Close buttons are implemented
as standalone buttons. This leads to the scenario, that
they break plattform-ui preferences on the one hand, as
well as not being the same order throughout.
This patch replaces all Ok/Close buttons with the Qt
button box, which handles the plattform-ui internally, and
additionally allways enforces the same order.
Change-Id: If62b90016b222322f60c0962da04c8277589a57f
Reviewed-on: https://code.wireshark.org/review/12335
Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from 96bf82c [IPMI] packet-scope isn't valid for use in BASE_CUSTOM functions.
adds b932ee8 Qt Frames: Use ButtonBox instead of buttons
Summary of changes:
ui/qt/address_editor_frame.cpp | 22 ++++++++++++----------
ui/qt/address_editor_frame.h | 4 ++--
ui/qt/address_editor_frame.ui | 21 ++++++++++-----------
ui/qt/column_editor_frame.cpp | 14 ++++++++------
ui/qt/column_editor_frame.h | 4 ++--
ui/qt/column_editor_frame.ui | 21 ++++++++++-----------
ui/qt/filter_expression_frame.cpp | 14 ++++++++------
ui/qt/filter_expression_frame.h | 4 ++--
ui/qt/filter_expression_frame.ui | 21 ++++++++++-----------
ui/qt/preference_editor_frame.cpp | 18 ++++++++++--------
ui/qt/preference_editor_frame.h | 4 ++--
ui/qt/preference_editor_frame.ui | 21 ++++++++++-----------
12 files changed, 86 insertions(+), 82 deletions(-)