Wireshark-commits: [Wireshark-commits] master 7e18954: Qt: fix generation of silence samples

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 1 Dec 2015 21:19:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7e18954a276f93c78e4ae7129ad97d73ec6d91aa
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7e18954 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: fix generation of silence samples
    
    The current code generates a shrill noise at least on Windows.
    Presumably memccpy does not behave as initially expected :)
    
    Change-Id: Id23a35d1d41ef4044b6a96c093a8fa927828f8b3
    Reviewed-on: https://code.wireshark.org/review/12337
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  7a3dadf   Bugfixes for EtherNet/IP and CIP
    adds  7e18954   Qt: fix generation of silence samples


Summary of changes:
 ui/qt/rtp_audio_stream.cpp |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)