Wireshark-commits: [Wireshark-commits] master d487c8c: SpeexDSP: Work around self assignments.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 1 Dec 2015 00:21:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d487c8c7e72666d5e926c4c6a499a0821796c694
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d487c8c by Gerald Combs (gerald@xxxxxxxxxxxxx):

    SpeexDSP: Work around self assignments.
    
    Disable -Wself-assign in speex/resample.c. Many macros (particularly
    SATURATE32PSHR) simply return the first argument.
    
    Change-Id: I3a8557833343e7b213031359e94af90d32d9f082
    Reviewed-on: https://code.wireshark.org/review/12315
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  0160397   mausb: The '&' operator is applied to bool type value found by PVS Studio (V564)
    adds  d487c8c   SpeexDSP: Work around self assignments.


Summary of changes:
 codecs/speex/resample.c |    6 ++++++
 1 file changed, 6 insertions(+)