[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a198f47c06723fabef174cb3983b26ead24f5bc9
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a198f47 by Peter Wu (peter@xxxxxxxxxxxxx):

    cmake: add asn1 target, avoid unnecessary rebuilds
    
    Add an "asn1" build target that rebuilds all ASN.1 dissectors.
    
    Do not always generate the ASN.1 dissector when invoking the
    "generate_dissector-PROTO" target. Use a special "packet-PROTO-stamp"
    file to detect whether the dissector is out of date.
    
    This indirection is needed because cmake removes output files from
    add_custom_command in the clean target, but we would like to keep the
    generated packet-PROTO.c files.
    
    Make all EXTRA_CNF and EXPORT_DEPENDS point to absolute paths for
    generated exported configs (PROTO-exp.cnf). This is done by automake too
    and is needed for proper dependency tracking. Example: when h225.cnf is
    updated, h225-exp.cnf needs to be generated. That is the purpose of the
    "generate-h225-exp.cnf" target. Now h235 (and other) dissectors need to
    be regenerated as well because the h225-exp.cnf is updated. This is why
    there is a separate add_custom_command and add_custom_target.
    
    Change-Id: I8cfc1f8f43cea595267b21eae30b4548f3407c0b
    Reviewed-on: https://code.wireshark.org/review/12080
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  edb3388   Fix ISO C restricts enumerator values to range of 'int' [-Wpedantic]
    adds  a198f47   cmake: add asn1 target, avoid unnecessary rebuilds


Summary of changes:
 .gitignore                           |    1 +
 asn1/CMakeLists.txt                  |    4 ++
 asn1/acp133/CMakeLists.txt           |   10 +--
 asn1/acse/CMakeLists.txt             |    2 +-
 asn1/ansi_map/CMakeLists.txt         |    2 +-
 asn1/camel/CMakeLists.txt            |    4 +-
 asn1/cmip/CMakeLists.txt             |    2 +-
 asn1/cmp/CMakeLists.txt              |    2 +-
 asn1/cms/CMakeLists.txt              |   10 +--
 asn1/crmf/CMakeLists.txt             |    2 +-
 asn1/dap/CMakeLists.txt              |   18 +++---
 asn1/disp/CMakeLists.txt             |   12 ++--
 asn1/dop/CMakeLists.txt              |   12 ++--
 asn1/dsp/CMakeLists.txt              |    8 +--
 asn1/ess/CMakeLists.txt              |    6 +-
 asn1/ftam/CMakeLists.txt             |    2 +-
 asn1/gprscdr/CMakeLists.txt          |    2 +-
 asn1/h225/CMakeLists.txt             |    4 +-
 asn1/h235/CMakeLists.txt             |    2 +-
 asn1/h323/CMakeLists.txt             |    2 +-
 asn1/h450/CMakeLists.txt             |    4 +-
 asn1/h460/CMakeLists.txt             |    6 +-
 asn1/h501/CMakeLists.txt             |    4 +-
 asn1/idmp/CMakeLists.txt             |    4 +-
 asn1/inap/CMakeLists.txt             |    4 +-
 asn1/lcsap/CMakeLists.txt            |    2 +-
 asn1/logotypecertextn/CMakeLists.txt |    2 +-
 asn1/lppe/CMakeLists.txt             |    2 +-
 asn1/mms/CMakeLists.txt              |    2 +-
 asn1/ocsp/CMakeLists.txt             |    4 +-
 asn1/p1/CMakeLists.txt               |   14 ++--
 asn1/p22/CMakeLists.txt              |   14 ++--
 asn1/p7/CMakeLists.txt               |    8 +--
 asn1/p772/CMakeLists.txt             |    4 +-
 asn1/pkcs1/CMakeLists.txt            |    2 +-
 asn1/pkcs12/CMakeLists.txt           |    6 +-
 asn1/pkinit/CMakeLists.txt           |    2 +-
 asn1/pkix1implicit/CMakeLists.txt    |    4 +-
 asn1/pkixac/CMakeLists.txt           |    4 +-
 asn1/pkixqualified/CMakeLists.txt    |    6 +-
 asn1/pkixtsp/CMakeLists.txt          |    2 +-
 asn1/pres/CMakeLists.txt             |    2 +-
 asn1/x509af/CMakeLists.txt           |    6 +-
 asn1/x509ce/CMakeLists.txt           |   10 +--
 asn1/x509if/CMakeLists.txt           |    2 +-
 asn1/x509sat/CMakeLists.txt          |    4 +-
 cmake/modules/UseAsn2Wrs.cmake       |  118 +++++++++++++++++++++-------------
 47 files changed, 192 insertions(+), 157 deletions(-)