Wireshark-commits: [Wireshark-commits] master be7bd77: Add BMT_NO_FLAGS for proto_tree_add_bitmask_

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 26 Nov 2015 08:38:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=be7bd77d993992c7bfa2aba43abf6cc9b5490cf5
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

be7bd77 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Add BMT_NO_FLAGS for proto_tree_add_bitmask_XXX_with_flags.
    
    This prevents some false positives for fix-encoding_args.pl which doesn't like constant values (like 0) passed as the last argument to any proto_tree_add_xxx call.
    
    Change-Id: Iab7b09b425bf0d48126533daa0e65490bd7b8890
    Reviewed-on: https://code.wireshark.org/review/12167
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a9f5d85   NSIS: refuse to install on Windows XP or Server 2003
    adds  be7bd77   Add BMT_NO_FLAGS for proto_tree_add_bitmask_XXX_with_flags.


Summary of changes:
 epan/dissectors/packet-fcels.c |    8 ++++----
 epan/dissectors/packet-ppp.c   |    4 ++--
 epan/proto.h                   |    1 +
 3 files changed, 7 insertions(+), 6 deletions(-)