Wireshark-commits: [Wireshark-commits] master 3d3eb15: Revert: Free cf->edt before free cf->epan wh

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 Nov 2015 20:28:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3d3eb159a757c1b7f3abc0d2c81f8e38e206243b
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3d3eb15 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Revert: Free cf->edt before free cf->epan when redissecting.
    
    Instead of freeing cf->edt before clearing the packet list, add an extra
    check to MainWindow::setMenusForSelectedTreeRow. Semi-blind attempt at
    fixing bug 11719.
    
    This reverts commit 8c211d51ef66b64c708f7ad079e7e7e913ac9f14.
    This reverts commit da71ccbf778cca5d9c48e010597570a40fd190c0.
    
    Bug: 11719
    Change-Id: Ifd07be414ffd03a40bdfa7110395c9542bd86fc4
    Reviewed-on: https://code.wireshark.org/review/11943
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  bdea0d4   Check for ECHILD, not for "not ECHILD".
    adds  3d3eb15   Revert: Free cf->edt before free cf->epan when redissecting.


Summary of changes:
 file.c                      |    4 ----
 ui/qt/main_window_slots.cpp |    2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)