URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=062e5b3118de4c4658f4379d3e84f273e3976a97
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
062e5b3 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):
Qt: setMenusForSelectedPacket when capture file is closed.
Moved setMenusForSelectedPacket() to captureFileClosed() because
capture_file_.capFile() is still valid in captureFileClosing().
Menu items depending on is_ip, is_tcp, is_udp, is_sctp, is_ssl,
is_rtp and is_lte_rlc must be disabled when closing the capture
file because many of the dialogs does crash when launched without
a valid frame selected.
All dialogs should probably have a guard for this to avoid crashes,
but that may be an exercise for an enhancement to add support for the
dialogs to follow the current loaded capture file.
Change-Id: If5837a355d08df76547572a25d46ffa539070de3
Reviewed-on: https://code.wireshark.org/review/11883
Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
Actions performed:
from c302554 Misc minor issues caught by cppcheck
adds 062e5b3 Qt: setMenusForSelectedPacket when capture file is closed.
Summary of changes:
ui/qt/main_window_slots.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)