Wireshark-commits: [Wireshark-commits] master-2.0 1530393: Catch failure of _open_osfhandle().

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 16 Nov 2015 21:41:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=15303931f287c9a0791e9f56d31cfbb02e9ac9c6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

1530393 by Guy Harris (guy@xxxxxxxxxxxx):

    Catch failure of _open_osfhandle().
    
    This may at least prevent the crash in bug 11702, by not returning
    "success" with bogus file handles of -1, if the opens fail due to
    leaks chewing up all the available slots.  More investigation needs to
    be done to see why we're leaking.
    
    Change-Id: I89ecff4b03bca140f05c838e1e2604a03409f803
    Ping-Bug: 11702
    Reviewed-on: https://code.wireshark.org/review/11881
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 9ec2cbb1c2f2917a9b9e149def8da8c072134524)
    Reviewed-on: https://code.wireshark.org/review/11888
    

Actions performed:

    from  e4da149   Qt: do not clear display filter when merging files
    adds  1530393   Catch failure of _open_osfhandle().


Summary of changes:
 capchild/capture_sync.c |   24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)