Wireshark-commits: [Wireshark-commits] master d66d379: Try retroactively applying the Qt folks' fix

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 15 Nov 2015 22:04:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d66d379ac89f4bdcb8ef2164fc82aa27b1ac7c3c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d66d379 by Guy Harris (guy@xxxxxxxxxxxx):

    Try retroactively applying the Qt folks' fix for QTBUG-47942.
    
    The current version of the fix only adds -fPIC under certain
    circumstances; we check whether it was added and, if it was, and those
    circumstances are *not* in effect, we remove it.
    
    Bug: 11643
    Change-Id: I75d0ff9b4781d7d4cd884a29bbce7d392939315c
    Reviewed-on: https://code.wireshark.org/review/11849
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  67ad1de   FindLUA.cmake: reject version 5.3
    adds  d66d379   Try retroactively applying the Qt folks' fix for QTBUG-47942.


Summary of changes:
 CMakeLists.txt |   70 ++++++++++++++++++++++----------------------------------
 1 file changed, 27 insertions(+), 43 deletions(-)