[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d7b0fc7d046154a393c9a1e5f4b2e9b5fee3738
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2d7b0fc by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    [GTK] Replace deprecated gdk_pixbuf_new_from_inline()
    
    Use GResource instead, if available. Add autotools and cmake compile time
    checks for build requirements (GIO >= 2.32 and GDK-Pixbuf >= 2.26).
    
    Merge all the various static pixbuf csource header files into
    a single pixbuf-csource.h header with external linkage through use of the
    tools/make-pixbuf-csource.pl script.
    
    Fix inline pixbuf build target for some image paths (broken for GTK
    in gb4a4de7).
    
    Add missing 'expert_ok.png' file to distribution (GTK only).
    
    Minor improvements to style/structure of ui/gtk/Makefile.am.
    
    Bug: 10750
    Change-Id: I031296b666ee8b92730400dfa6f71f9ee4304863
    Reviewed-on: https://code.wireshark.org/review/10992
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1ab019f   Fix up documentation of RPM packages.
    adds  2d7b0fc   [GTK] Replace deprecated gdk_pixbuf_new_from_inline()


Summary of changes:
 .gitignore                     |    2 +
 Makefile.am                    |    1 +
 configure.ac                   |    8 +
 tools/checklicenses.py         |    8 +-
 tools/make-pixbuf-csource.pl   |   71 +
 ui/gtk/CMakeLists.txt          |   36 +
 ui/gtk/Makefile.am             |  177 +-
 ui/gtk/Makefile.common         |  427 +-
 ui/gtk/Makefile.nmake          |   21 +-
 ui/gtk/about_dlg.c             |    8 +-
 ui/gtk/capture_comment_icons.h |  237 -
 ui/gtk/capture_dlg.c           |   15 +-
 ui/gtk/capture_if_dlg.c        |   27 +-
 ui/gtk/expert_comp_dlg.c       |   29 +-
 ui/gtk/expert_indicators.h     |  381 --
 ui/gtk/gui_utils.c             |   55 +-
 ui/gtk/gui_utils.h             |   29 +-
 ui/gtk/layouts.h               | 2948 -----------
 ui/gtk/main.c                  |  139 +-
 ui/gtk/main.gresources.xml     |   65 +
 ui/gtk/main_statusbar.c        |   25 +-
 ui/gtk/main_welcome.c          |   16 +-
 ui/gtk/network_icons.h         |  263 -
 ui/gtk/pipe_icon.h             |   70 -
 ui/gtk/pixbuf-csource.c        |10489 ++++++++++++++++++++++++++++++++++++++++
 ui/gtk/pixbuf-csource.h        |   57 +
 ui/gtk/prefs_layout.c          |   35 +-
 ui/gtk/remote_icons.h          |  224 -
 ui/gtk/stock_icons.c           |   59 +-
 ui/gtk/toolbar_icons.h         | 1479 ------
 ui/gtk/wsicon.h                | 1644 -------
 ui/gtk/wsiconcap.h             | 1529 ------
 ui/gtk/wssplash.h              | 1867 -------
 33 files changed, 11389 insertions(+), 11052 deletions(-)
 create mode 100644 tools/make-pixbuf-csource.pl
 delete mode 100644 ui/gtk/capture_comment_icons.h
 delete mode 100644 ui/gtk/expert_indicators.h
 delete mode 100644 ui/gtk/layouts.h
 create mode 100644 ui/gtk/main.gresources.xml
 delete mode 100644 ui/gtk/network_icons.h
 delete mode 100644 ui/gtk/pipe_icon.h
 create mode 100644 ui/gtk/pixbuf-csource.c
 create mode 100644 ui/gtk/pixbuf-csource.h
 delete mode 100644 ui/gtk/remote_icons.h
 delete mode 100644 ui/gtk/toolbar_icons.h
 delete mode 100644 ui/gtk/wsicon.h
 delete mode 100644 ui/gtk/wsiconcap.h
 delete mode 100644 ui/gtk/wssplash.h