Wireshark-commits: [Wireshark-commits] master e240ad8: Use format_text() when displaying, not when

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Nov 2015 06:30:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e240ad882bc1e133e76b8308a76884d12b265253
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e240ad8 by Guy Harris (guy@xxxxxxxxxxxx):

    Use format_text() when displaying, not when handing to AirPDcap.
    
    format_text() is specifically intended to handle strings when displaying
    them to the user; code such as AirPDCap, which doesn't display strings
    to the user, should be handed the raw SSID.
    
    Put in a comment indicating what we probably *should* be doing here.
    
    Bug: 11685
    
    Change-Id: Ic30114c35d1d8f3d791ae904e33a4d81ddc215ec
    Reviewed-on: https://code.wireshark.org/review/11757
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  90d9710   IPv6: Register extension header fields under the appropriate protocol
    adds  e240ad8   Use format_text() when displaying, not when handing to AirPDcap.


Summary of changes:
 epan/dissectors/packet-ieee80211.c |   72 ++++++++++++++++++++++++++++--------
 1 file changed, 56 insertions(+), 16 deletions(-)