Wireshark-commits: [Wireshark-commits] master a4981a2: Qt: fixes to 'Edit Column' dialog

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 Nov 2015 08:16:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a4981a279a616c7dfc9a0887ba8511851cc8ec22
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a4981a2 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: fixes to 'Edit Column' dialog
    
    - set field name and occurrence when editing a custom column
    - convert occurrence number to a QString
    - disable OK button when syntax is incorrect or empty for a custom column
    - update syntax state when opening the edit dialog or when switching between custom and normal column
    
    Bug: 11433
    Change-Id: Ia8424474dd250c78a0b503e0e9d89c322f4f86a9
    Reviewed-on: https://code.wireshark.org/review/11705
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  5f4c9b2   Make routines used only within wiretap/merge.c static.
    adds  a4981a2   Qt: fixes to 'Edit Column' dialog


Summary of changes:
 ui/qt/column_editor_frame.cpp |   43 +++++++++++++++++++++++++++++++----------
 ui/qt/column_editor_frame.h   |    2 +-
 2 files changed, 34 insertions(+), 11 deletions(-)