Wireshark-commits: [Wireshark-commits] master 6ae50eb: Call wtap_dump_open_check() in wtap_dump_ini

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Nov 2015 11:29:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6ae50ebf28cd40d5c7e1ef5493c22e896564c4f2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6ae50eb by Guy Harris (guy@xxxxxxxxxxxx):

    Call wtap_dump_open_check() in wtap_dump_init_dumper().
    
    The callers of wtap_dump_init_dumper() always call
    wtap_dump_open_check() first, with the same arguments in all cases; pull
    the latter call into wtap_dump_init_dumper() itself.
    
    Change-Id: I2b44dc3a018745e175b5c74ff1a346749fec2b71
    Reviewed-on: https://code.wireshark.org/review/11681
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  b3fa7e5   Add a comment for is_stdout.
    adds  6ae50eb   Call wtap_dump_open_check() in wtap_dump_init_dumper().


Summary of changes:
 wiretap/file_access.c |   20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)