Wireshark-commits: [Wireshark-commits] master-2.0 5db1187: Call the dumper routine to finish write

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 9 Nov 2015 19:55:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5db1187b8f3988606d70281a59280c401823ce5f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

5db1187 by Guy Harris (guy@xxxxxxxxxxxx):

    Call the dumper routine to finish write a file the "finish" routine.
    
    It doesn't actually *close* any handle, so it's best called a "finish"
    routine rather than a "close" routine.
    
    In libwiretap modules, don't bother setting the finish routine pointer
    to null - it's already initialized to null (it's probably best not to
    require modules to set it).
    
    Change-Id: I19554f3fb826db495f17b36600ae36222cbc21b0
    Reviewed-on: https://code.wireshark.org/review/11659
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 09f5ff4fc6895f375b3ea07f6151d8e09377fd52)
    Reviewed-on: https://code.wireshark.org/review/11660
    

Actions performed:

    from  73841fd   androiddump: make nanoseconds int
    adds  5db1187   Call the dumper routine to finish write a file the "finish" routine.


Summary of changes:
 epan/wslua/wslua.h              |    2 +-
 epan/wslua/wslua_file_handler.c |   32 ++++++++++++++++----------------
 wiretap/5views.c                |    6 +++---
 wiretap/btsnoop.c               |    6 ++----
 wiretap/commview.c              |    1 -
 wiretap/erf.c                   |    1 -
 wiretap/eyesdn.c                |    1 -
 wiretap/file_access.c           |    6 +++---
 wiretap/k12.c                   |    4 ++--
 wiretap/lanalyzer.c             |   10 +++++-----
 wiretap/libpcap.c               |    1 -
 wiretap/logcat.c                |    1 -
 wiretap/logcat_text.c           |    1 -
 wiretap/netmon.c                |    6 +++---
 wiretap/nettl.c                 |    1 -
 wiretap/netxray.c               |   12 ++++++------
 wiretap/ngsniffer.c             |    6 +++---
 wiretap/pcapng.c                |    8 ++++----
 wiretap/snoop.c                 |    1 -
 wiretap/visual.c                |    6 +++---
 wiretap/wtap-int.h              |   16 ++++++++--------
 21 files changed, 59 insertions(+), 69 deletions(-)