[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0162e54075bb7ad967a85736b3c8addd53d86de5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0162e54 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up includes of unistd.h, fcntl.h, and sys/stat.h.
    
    Have wsutil/file_util.h include them on UN*X, just as it includes io.h
    on Windows, so we can have a rule of "if you do file operations, include
    <wsutil/file_util.h> and use the routines in it".
    
    Remove includes of unistd.h, fcntl.h, and sys/stat.h that aren't
    necessary (whether because of the addition of them to wsutil/file_util.h
    or because they weren't needed in the first place).
    
    Change-Id: Ie241dd74deff284e39a5f690a297dbb6e1dc485f
    Reviewed-on: https://code.wireshark.org/review/11619
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  24bfb7e   column-utils: Refactor col_append_port() to col_append_ports()
    adds  0162e54   Clean up includes of unistd.h, fcntl.h, and sys/stat.h.


Summary of changes:
 capchild/capture_sync.c       |    8 --------
 capinfos.c                    |    4 ----
 capture_opts.c                |    4 ----
 capture_stop_conditions.c     |    1 -
 captype.c                     |    4 ----
 dumpcap.c                     |   12 ------------
 epan/addr_resolv.c            |    4 ----
 epan/disabled_protos.c        |    4 ----
 epan/dissectors/packet-lmp.c  |    4 ----
 epan/dissectors/packet-rsvp.c |    4 ----
 epan/prefs.c                  |    4 ----
 file.c                        |    8 --------
 fileset.c                     |   12 ------------
 mergecap.c                    |    8 --------
 plugins/mate/mate_util.h      |    4 ----
 randpkt.c                     |    8 --------
 rawshark.c                    |   12 ------------
 reordercap.c                  |    4 ----
 ringbuffer.c                  |    8 --------
 text2pcap.c                   |    4 ----
 tfshark.c                     |   12 ------------
 tshark.c                      |   12 ------------
 ui/capture.c                  |    4 ----
 ui/cli/tap-follow.c           |    4 ----
 ui/export_object.c            |    8 --------
 ui/filters.c                  |    4 ----
 ui/gtk/capture_file_dlg.c     |    4 ----
 ui/gtk/export_sslkeys.c       |    8 --------
 ui/gtk/fileset_dlg.c          |    4 ----
 ui/gtk/firewall_dlg.c         |    8 --------
 ui/gtk/follow_stream.c        |    3 ---
 ui/gtk/follow_tcp.c           |    4 ----
 ui/gtk/iax2_analysis.c        |    8 --------
 ui/gtk/main.c                 |    4 ----
 ui/gtk/packet_panes.c         |    8 --------
 ui/gtk/rtp_analysis.c         |    8 --------
 ui/mcast_stream.c             |    3 ---
 ui/qt/main_window_slots.cpp   |    8 --------
 ui/rtp_stream.c               |    4 ----
 ui/text_import.c              |    4 ----
 ui/traffic_table_ui.c         |    3 ---
 wiretap/ber.c                 |    4 ----
 wiretap/file_access.c         |    8 --------
 wiretap/file_wrappers.c       |    7 -------
 wiretap/stanag4607.c          |    4 ----
 wiretap/tnef.c                |    4 ----
 wiretap/wtap.c                |    4 ----
 wsutil/file_util.h            |   20 +++++++++++++-------
 wsutil/filesystem.c           |   12 ------------
 wsutil/plugins.c              |    4 ----
 wsutil/tempfile.c             |    8 --------
 wsutil/u3.c                   |    6 +-----
 52 files changed, 14 insertions(+), 313 deletions(-)