Wireshark-commits: [Wireshark-commits] master 3b125e7: Make rect_on_screen Qt4-compatible.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 6 Nov 2015 20:28:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b125e7aefee18a4d07bfc2fd76a3524c169bf3c
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3b125e7 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Make rect_on_screen Qt4-compatible.
    
    Use QDesktopWidget instead of QGuiApplication + QScreen. The former
    exists in the Qt 4 API.
    
    Ping-Bug: 11568
    Change-Id: Icfbe9f78659b28efbc86061f94d946f70ab6dc41
    Reviewed-on: https://code.wireshark.org/review/11604
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  1799834   Fix crash in internals menu dissector tables dialog by supporting FT_GUID type.
    adds  3b125e7   Make rect_on_screen Qt4-compatible.


Summary of changes:
 ui/qt/qt_ui_utils.cpp |    9 +++++----
 ui/qt/qt_ui_utils.h   |    2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)