Wireshark-commits: [Wireshark-commits] master ced7412: TCP: replace some dissector asserts by a ret

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 1 Nov 2015 03:21:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ced7412c1062a74afc3f973fe1e3d1238a0acf40
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ced7412 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    TCP: replace some dissector asserts by a return
    
    It prevents an assert in case of malformed packet
    
    Bug: 11662
    Change-Id: If5d7196c7e6ecd0ffe8ed97213dbd64bc1f69cbb
    Reviewed-on: https://code.wireshark.org/review/11464
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  9180c27   [ssh] don't THROW() an exception from a dissector
    adds  ced7412   TCP: replace some dissector asserts by a return


Summary of changes:
 epan/dissectors/packet-tcp.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)