Wireshark-commits: [Wireshark-commits] master 6c9ddbd: EtherCAT: wrong display name

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 29 Oct 2015 14:32:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6c9ddbda65408ed15af69d74bfaa881e308f63b2
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6c9ddbd by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    EtherCAT: wrong display name
    
    Wireshark is showing 2 consecutive bytes named "SubIdx" in a SDO info request (OpCode = 0x5) and response (OpCode = 0x6). But the second byte should be the "ValueInfo" instead in both request and response.
    
    Issue reported by ThoKu
    
    Bug:11652
    Change-Id: I7f6395208d38e714071de5dbb40e3ddb9829f210
    Reviewed-on: https://code.wireshark.org/review/11397
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8c48529   tools/checkAPIs.pl: improve the hf_ error messages
    adds  6c9ddbd   EtherCAT: wrong display name


Summary of changes:
 plugins/ethercat/packet-ecatmb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)